From: Tom Gundersen <hidden> Date: 2013-09-06 11:48:10
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Cc: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
Hi,
Sorry for the resend, got the ml address wrong.
-t
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)}info->pseudo_palette=(void*)(info+1);+dev_info(&pdev->dev,"framebuffer at 0x%lx, mapped to 0x%p\n",+info->fix.smem_start,info->screen_base);+dev_info(&pdev->dev,"format=%s, mode=%dx%dx%d, linelength=%d\n",+params.format->name,+info->var.xres,info->var.yres,+info->var.bits_per_pixel,+info->fix.line_length);+ret=register_framebuffer(info);if(ret<0){dev_err(&pdev->dev,"Unable to register simplefb: %d\n",ret);
From: David Herrmann <hidden> Date: 2013-09-07 11:16:25
Hi Tom
On Fri, Sep 6, 2013 at 1:49 PM, Tom Gundersen [off-list ref] wrote:
quoted hunk
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Cc: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
Hi,
Sorry for the resend, got the ml address wrong.
-t
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)
@@ -220,6 +220,14 @@ static int simplefb_probe(struct platform_device *pdev)}info->pseudo_palette=(void*)(info+1);+dev_info(&pdev->dev,"framebuffer at 0x%lx, mapped to 0x%p\n",+info->fix.smem_start,info->screen_base);
Could we get smem_len, too? Something like:
dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped
to 0x%p\n",
info->fix.smem_start, (unsigned
long)info->fix.smem_len, info->screen_base);
(smem_len is __u32, so cast it to avoid truncation if it's defined as
long somewhere. Not sure whether we actually have 16bit int somewhere,
though)
Cheers
David
From: Tom Gundersen <hidden> Date: 2013-09-07 11:42:37
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Acked-by: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
v2: also print smem_len as requested by David
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)
On Sat, Sep 7, 2013 at 1:43 PM, Tom Gundersen [off-list ref] wrote:
+ dev_info(&pdev->dev, "framebuffer at 0x%lx, 0x%lx bytes, mapped to 0x%p\n",
+ info->fix.smem_start, (unsigned long) info->fix.smem_len,
Please drop the cast, and use 0x%x. __u32 is unsigned int everywhere (where it
matters --- we don't do 16-bit ints).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Tom Gundersen <hidden> Date: 2013-09-07 14:07:34
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Acked-by: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
v2: also print smem_len, as requested by David
v3: don't cast, as requested by Geert
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)
From: Tom Gundersen <hidden> Date: 2013-10-01 16:45:38
On Sat, Sep 7, 2013 at 4:08 PM, Tom Gundersen [off-list ref] wrote:
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Acked-by: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
v2: also print smem_len, as requested by David
v3: don't cast, as requested by Geert
Jean-Christophe and Tomi,
What's the status of this, did either of you pick it up for 3.12 or 3.13?
Cheers,
Tom
From: Tomi Valkeinen <hidden> Date: 2013-10-09 09:06:06
On 07/09/13 17:08, Tom Gundersen wrote:
quoted hunk
This is similar to the output printed by efifb.
Signed-off-by: Tom Gundersen <redacted>
Acked-by: Stephen Warren <redacted>
Cc: David Herrmann <redacted>
---
v2: also print smem_len, as requested by David
v3: don't cast, as requested by Geert
drivers/video/simplefb.c | 8 ++++++++
1 file changed, 8 insertions(+)