Re: [PATCH v2 10/24] video: da8xx-fb: fb_set_par support
From: Darren Etheridge <hidden>
Date: 2013-08-01 13:54:12
From: Darren Etheridge <hidden>
Date: 2013-08-01 13:54:12
Tomi Valkeinen [off-list ref] wrote on Wed [2013-Jul-31 14:38:52 +0300]:
quoted
+static inline bool da8xx_fb_is_raster_enabled(void) +{ + return !!(lcdc_read(LCD_RASTER_CTRL_REG) & LCD_RASTER_ENABLE); +}See Documentation/CodingStyle about inline. I think, generally, it's better not to use inline at all in normal functions. Let the compiler decide. Even more so with funcs like da8xx_fb_is_raster_enabled(), which I guess is only used rarely. There are some inlines added in other patches in the series also.
I have added a new patch to the update series that removes the use of inline from all offending places. Darren