RE: [PATCH v2 10/24] video: da8xx-fb: fb_set_par support

From
Etheridge, Darren <hidden>
Date
2013-07-31 18:56:11
Reply to
Darren Etheridge, 2013-07-30
quoted

+static int da8xxfb_set_par(struct fb_info *info) {
+	struct da8xx_fb_par *par = info->par;
+	int ret;
+	bool raster = da8xx_fb_is_raster_enabled();
+
+	if (raster)
+		lcd_disable_raster(true);
+	else
+		lcd_disable_raster(false);
This looks odd. If raster is enabled, you disable it. And if raster is disabled,
you disable it.
I corrected this one in patch 0011 - I agree this code is very confusing.
Thread (7 messages) 7 messages, 2 authors, last reply 2013-08-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help