Re: [PATCH 3/3] fb: backlight: HX8357: Add HX8369 support

Hi Jingoo,

On Tue, Jul 16, 2013 at 11:04:09AM +0900, Jingoo Han wrote:

On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:

quoted

From: Alexandre Belloni <redacted>

Add support for the Himax HX8369 controller as it is quite similar to the
hx8357.

Signed-off-by: Alexandre Belloni <redacted>
Signed-off-by: Maxime Ripard <redacted>

Hi Maxime Ripard,

I reviewed this patch with Himax HX8369 datasheet.
I cannot find any problems. It looks good.

However, if possible, please add comment on huge delays such as
msleep(120), msleep(100), etc.

Right. I'll send a follow-up patch if this is merged right away, or
merge the comments in the next iteration of the patches.

Acked-by: Jingoo Han <redacted>

Thanks for taking the time to review this!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com