Thread (12 messages) 12 messages, 4 authors, 2013-07-22

Re: [PATCH 2/3] video: hx8357: Make IM pins optional

From: Mike Galbraith <hidden>
Date: 2013-07-16 03:32:42
Also in: linux-arm-kernel, lkml

On Tue, 2013-07-16 at 09:49 +0900, Jingoo Han wrote: 
On Tuesday, July 16, 2013 12:27 AM, Maxime Ripard wrote:
quoted
+
+			ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i],
+						    GPIOF_OUT_INIT_LOW, "im_pins");
This makes a checkpatch warning such as 'WARNING: line over 80 characters'.
How about the following?

			ret = devm_gpio_request_one(&spi->dev, lcd->im_pins[i],
						GPIOF_OUT_INIT_LOW, "im_pins");
IIRC, some maintainers gripe (davem?) when they see such alignment,
preferring the original arg below arg alignment vs strict 80 column.

-Mike
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help