Re: [RFC 1/6] fbdev: simplefb: add init through platform_data

Hi

On Wed, Jun 26, 2013 at 10:39 PM, Stephen Warren [off-list ref] wrote:

On 06/24/2013 04:27 PM, David Herrmann wrote:

quoted

If we create proper platform-devices in x86 boot-code, we can use simplefb
for VBE or EFI framebuffers, too. However, there is normally no OF support
so we introduce a platform_data object so x86 boot-code can pass the
paramaters via plain old platform-data.

This also removes the OF dependency as it is not needed. The headers
provide proper dummies for the case OF is disabled.

Furthermore, we move the FORMAT-definitions to the common platform header
so initialization code can use it to transform "struct screen_info" to
the right format-name.

quoted

diff --git a/include/linux/platform_data/simplefb.h b/include/linux/platform_data/simplefb.h

quoted

+/* the framebuffer size and location is available as IORESOURCE_MEM */
+struct simplefb_platform_data {
+     u32 width;
+     u32 height;
+     u32 stride;
+     char format[64];
+};

Any reason not to make format:

const char *format;

You should be able to initialize that just as easily in platform code,
either as static data or at runtime, I think.

That makes sense. I fixed it up.

Thanks
David