Re: [RFC 3/6] drm: add SimpleDRM driver
- From
- Andy Lutomirski <luto@amacapital.net>
- Date
- 2013-06-25 01:05:16
- Also in
- dri-devel, lkml
- Reply to
- David Herrmann, 2013-06-24
On 06/24/2013 03:27 PM, David Herrmann wrote:
+ sdrm->fb_map = ioremap(sdrm->fb_base, sdrm->fb_size);
This should probably be ioremap_wc. Otherwise it will be *really* slow if used in legacy mode and it may cause conflicts with the pgprot_writecombine mode for mmap. (Watching boot messages go by on fbcon on efifb was like using an old 2400 baud modem before I made the corresponding change to efifb.) --Andy