Re: [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings

From
Timur Tabi <hidden>
Date
2013-05-31 15:06:32
Also in
lkml
Reply to
Arnd Bergmann, 2013-05-31
On 05/31/2013 09:56 AM, Arnd Bergmann wrote:
Yes, unfortunately, this is what all other frame buffer drivers do
at the moment. It is technically not correct, but most architectures
are able to call readl/writel on regular memory, or dereference
__iomem tokens, so we often get away with it. It's probably not
worth fixing it in the fbdev code base as that would be a huge
change, and people are migrating to DRM/KMS.
But why bother fixing this bug if it just makes things worse?  Sparse is
supposed to warn us about bad code.  This patch doesn't fix the bug, it
just masks the warnings!

-- 
Timur Tabi
Thread (21 messages) 21 messages, 4 authors, last reply 2013-05-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help