Re: [PATCH v3 7/8] video: xilinxfb: Fix sparse warnings

From
Timur Tabi <hidden>
Date
2013-05-31 13:41:36
Also in
lkml
Reply to
Michal Simek, 2013-05-31
On 05/31/2013 08:37 AM, Michal Simek wrote:
The same is for Microblaze. Driver shares fb_virt for IO memory
and for allocated memory. The purpose of this driver wasn't
to change the driver logic just resolved sparse warnings.
The other way is also wrong.
I have compiled this driver with ppc toolchain and it should
remove sparse warnings for PPC.
But it's not I/O memory.  It's regular memory.  __iomem is for
memory-mapped I/O, which is limited to a specific range of memory locations.

If sometimes you use regular memory for the framebuffer, and other times
you use real I/O memory for the framebuffer, then you should have two
different pointers.

-- 
Timur Tabi
Thread (21 messages) 21 messages, 4 authors, last reply 2013-05-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help