Re: [PATCH -next] backlight: adp8860: fix error return code in adp8860_led_probe()
From: Jingoo Han <hidden>
Date: 2013-03-25 04:29:13
Also in:
lkml
On Friday, March 22, 2013 8:30 PM, Wei Yongjun wrote:
From: Wei Yongjun <redacted> Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun <redacted>
CC'ed Andrdew Morton, linux-kernel@vger.kernel.org Acked-by: Jingoo Han <redacted>
quoted hunk ↗ jump to hunk
--- drivers/video/backlight/adp8860_bl.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 6bb7f36..75b10f8 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c@@ -249,12 +249,14 @@ static int adp8860_led_probe(struct i2c_client *client) if (led_dat->id > 7 || led_dat->id < 1) { dev_err(&client->dev, "Invalid LED ID %d\n", led_dat->id); + ret = -EINVAL; goto err; } if (pdata->bl_led_assign & (1 << (led_dat->id - 1))) { dev_err(&client->dev, "LED %d used by Backlight\n", led_dat->id); + ret = -EBUSY; goto err; } --To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html