[PATCH -next] backlight: adp8860: fix error return code in adp8860_led_probe()
From: Wei Yongjun <hidden>
Date: 2013-03-22 11:30:20
Subsystem:
adp8860 backlight driver (adp8860/adp8861/adp8863), backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Michael Hennerich, Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
From: Wei Yongjun <redacted> Fix to return a negative error code from the error handling case instead of 0, as returned elsewhere in this function. Signed-off-by: Wei Yongjun <redacted> --- drivers/video/backlight/adp8860_bl.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
index 6bb7f36..75b10f8 100644
--- a/drivers/video/backlight/adp8860_bl.c
+++ b/drivers/video/backlight/adp8860_bl.c@@ -249,12 +249,14 @@ static int adp8860_led_probe(struct i2c_client *client) if (led_dat->id > 7 || led_dat->id < 1) { dev_err(&client->dev, "Invalid LED ID %d\n", led_dat->id); + ret = -EINVAL; goto err; } if (pdata->bl_led_assign & (1 << (led_dat->id - 1))) { dev_err(&client->dev, "LED %d used by Backlight\n", led_dat->id); + ret = -EBUSY; goto err; }