[PATCH 3/3] fb: smscufx: fix hang at disconnect
From: Alexander Holler <hidden>
Date: 2013-01-25 18:50:23
Also in:
lkml, stable
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
When a device was disconnected the driver may hang at waiting for urbs it never will get. Fix this by using a timeout while waiting for the used semaphore. There is still a memory leak if a timeout happens, but at least the driver now continues his disconnect routine. Cc: <redacted> Signed-off-by: Alexander Holler <redacted> --- drivers/video/smscufx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c
index 97bd662..f26fa4f 100644
--- a/drivers/video/smscufx.c
+++ b/drivers/video/smscufx.c@@ -1838,8 +1838,9 @@ static void ufx_free_urb_list(struct ufx_data *dev) /* keep waiting and freeing, until we've got 'em all */ while (count--) { - /* Getting interrupted means a leak, but ok at shutdown*/ - ret = down_interruptible(&dev->urbs.limit_sem); + /* Timeout likely occurs at disconnect (resulting in a leak) */ + ret = down_timeout_killable(&dev->urbs.limit_sem, + FREE_URB_TIMEOUT); if (ret) break;
--
1.7.11.7