Re: [PATCH 1/2 v6] of: add helper to parse display timings

On Sat, Oct 20, 2012 at 09:59:51PM +0200, Thierry Reding wrote:

On Thu, Oct 04, 2012 at 07:59:19PM +0200, Steffen Trumtrar wrote:
[...]

quoted

diff --git a/include/linux/of_display_timings.h b/include/linux/of_display_timings.h

[...]

quoted

+struct display_timings {
+	unsigned int num_timings;
+	unsigned int default_timing;
+
+	struct signal_timing **timings;
+};
+
+struct timing_entry {
+	u32 min;
+	u32 typ;
+	u32 max;
+};
+
+struct signal_timing {

I'm slightly confused by the naming here. signal_timing seems overly
generic in this context. Is there any reason why this isn't called
display_timing or even display_mode?

You are right. I actually already changed that, for the same reasons.
It will be called display_timing in the next version, as I think that's what it really
is.

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |