On Thu, Sep 13, 2012 at 09:24:53AM -0600, Stephen Warren wrote:
On 09/13/2012 01:29 AM, Mark Brown wrote:
quoted
The driver knows the power sequence. Having to type the same sequence
into the DT or platform data for each board using the device wouuld be
retarded so we need the drivers to be able to give the sequence to the
library if they're going to be able to reuse it (which is a lot of what
Tomi is talking about).
I believe that's trivial to implement. The relevant function is:
Right, that's what I'm saying - the code is mostly there now.
It's up to the driver whether pseq comes from platform data or is
hard-coded into the driver (or not provided at all, for the DT case).
So, the only change needed to convert a "hard-coded" driver to this API
is to convert the current custom data structure (or code) that describes
the sequence into a struct platform_power_seq_set.
The framework could still help by providing ways to avoid having to copy
the structure and fill in the blanks for GPIO numbers (and anything else
that is numbered rather than named) by hand.