Re: [rtc-linux] [PATCHv3 8/9] arm: vt8500: gpio: Devicetree support for arch-vt8500
From: Linus Walleij <hidden>
Date: 2012-08-22 09:21:38
Also in:
linux-arm-kernel, linux-devicetree, linux-serial, lkml
On Tue, Aug 21, 2012 at 10:47 PM, Tony Prisk [off-list ref] wrote:
Converted the existing arch-vt8500 gpio to a platform_device. Added support for WM8505 and WM8650 GPIO controllers.
(...)
+ unsigned val;
I asked about the datatype for this "val", it sure isn't "unsigned". I suspected the registers were only 8bit and so it should be u8. But atleast use u32 if you must use all these bits. (...)
quoted hunk ↗ jump to hunk
+ val = readl(vt8500_chip->base + vt8500_chip->regs->en); + val |= BIT(offset); + writel(val, vt8500_chip->base + vt8500_chip->regs->en);
BTW: have you considered [readl|writel]_relaxed? Yours, Linus Walleij