Thread (74 messages) 74 messages, 3 authors, 2012-09-03

Re: [PATCH v2 06/23] OMAP_VOUT: Remove manager->device references

From: Tomi Valkeinen <hidden>
Date: 2012-08-31 12:11:58
Also in: linux-omap

On Thu, 2012-08-30 at 17:10 +0530, Archit Taneja wrote:
With the introduction of output entities, managers will now connect to outputs.
Use the helper op for managers named get_device. This will abstract away the
information on how to get the device from an overlay manager.

Using the helper function will reduce the number of pointer dereferences a user
of OMAPDSS needs to do and reduce risk of a NULL dereference.
Almost all the uses here seem to be getting the dssdev from an overlay.
Would it make sense to implement get_device for an ovl? That would
reduce all the ovl->manager ? ovl->manager->get_device(ovl->manager) :
NULL; code to ovl->get_device(ovl).

 Tomi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help