Hi Jean,

On Tue, 2012-06-05 at 14:17 +0200, Jean Pihet wrote:

Hi Tomi,

I am using a mainline kernel (3.5.0-rc1) with the patches below integrated.
I have an issue with suspend/resume on OMAP3 Beagleboard, where the
system hangs at resume time.

Here below is a log with the option no_console_suspend set and a few
added messages in case of null pointer in _od_resume_noirq.
It looks like there is no omap_device associated to the "omapdss_dpi" pdev.

What do you think? How to fix this?
Sorry I know there have been some discussions on the lists but I am
not aware of all the details in the devices creation for DSS.

/ # echo mem > /sys/power/state
[   23.262298] PM: Syncing filesystems ... done.
[   23.295501] Freezing user space processes ... (elapsed 0.02 seconds) done.
[   23.326507] Freezing remaining freezable tasks ... (elapsed 0.02 seconds) don
e.
[   23.502197] PM: suspend of devices complete after 163.766 msecs
[   23.511932] PM: late suspend of devices complete after 3.418 msecs
[   23.524444] PM: noirq suspend of devices complete after 5.860 msecs
[   23.531249] Disabling non-boot CPUs ...
[   24.476562] Powerdomain (per_pwrdm) didn't enter target state 1
[   24.482818] Powerdomain (core_pwrdm) didn't enter target state 1
[   24.489166] Could not enter target state in pm_suspend
[   24.495147] *** _od_resume_noirq: od=NULL, dev=0xc78bcc08
[   24.500915] *** _od_resume_noirq: od=NULL, pdev=0xc78bcc00
[   24.506805] *** _od_resume_noirq: od=NULL, pdev->name:omapdss_dpi
[   24.513336] Unable to handle kernel NULL pointer dereference at virtual addre
ss 00000018
[   24.521942] pgd = c62f0000
[   24.524841] [00000018] *pgd=862c1831, *pte=00000000, *ppte=00000000
[   24.531524] Internal error: Oops: 17 [#1] SMP ARM
[   24.536529] Modules linked in:
[   24.539764] CPU: 0    Not tainted  (3.5.0-rc1-00010-g5041caa-dirty #131)
[   24.546844] PC is at _od_resume_noirq+0x1c/0xac
[   24.551635] LR is at _od_resume_noirq+0x94/0xac
...

I'm on leave currently, so I can't test it right now. But can you try
the attached patch? Or even better, try merging the tag:

git://gitorious.org/linux-omap-dss2/linux.git tags/omapdss-for-3.5-rc2

which contains the included patch plus a couple other fixes.

 Tomi