Thread (7 messages) 7 messages, 3 authors, 2012-05-10

Re: [PATCH] OMAPDSS: TFP410: use gpio_set_value_cansleep

From: Tony Lindgren <tony@atomide.com>
Date: 2012-05-09 23:37:46
Also in: linux-omap

* Russ Dill [off-list ref] [120509 15:53]:
On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren [off-list ref] wrote:
quoted
* Russ Dill [off-list ref] [120509 15:12]:
quoted
The Beagleboard xM gpio used for TFP410 powerdown is connected through
an I2C attached chip which means setting the GPIO can sleep. Code that
calls tfp410_power_on/off holds a mutex, so sleeping should be fine.
What's the error without this patch? Or just no display?

Just wondering if it's safe to merge Tomi's clean up series to
arm-soc tree..
The only platform that has a problem is Beagleboard xM, and that is
only after 'ARM: OMAP: Cleanup Beagleboard DVI reset gpio' is applied.
Since the context actually can sleep, the only consequence is a
WARN_ON statement.

So yes, it should be safe.
Well since I have not actually merged it with other branches yet, I'll wait
for Tomi to apply that and repull his for-l-o-3.5 branch.

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help