On Wed, May 9, 2012 at 3:14 PM, Tony Lindgren [off-list ref] wrote:

* Russ Dill [off-list ref] [120509 15:12]:

quoted

The Beagleboard xM gpio used for TFP410 powerdown is connected through
an I2C attached chip which means setting the GPIO can sleep. Code that
calls tfp410_power_on/off holds a mutex, so sleeping should be fine.

What's the error without this patch? Or just no display?

Just wondering if it's safe to merge Tomi's clean up series to
arm-soc tree..

The only platform that has a problem is Beagleboard xM, and that is
only after 'ARM: OMAP: Cleanup Beagleboard DVI reset gpio' is applied.
Since the context actually can sleep, the only consequence is a
WARN_ON statement.

So yes, it should be safe.

quoted

Signed-off-by: Russ Dill <redacted>
---
 drivers/video/omap2/displays/panel-tfp410.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-tfp410.c b/drivers/video/omap2/displays/panel-tfp410.c
index 52637fa..1266520 100644
--- a/drivers/video/omap2/displays/panel-tfp410.c
+++ b/drivers/video/omap2/displays/panel-tfp410.c

@@ -68,7 +68,7 @@ static int tfp410_power_on(struct omap_dss_device *dssdev)

              goto err0;

      if (gpio_is_valid(ddata->pd_gpio))
-             gpio_set_value(ddata->pd_gpio, 1);
+             gpio_set_value_cansleep(ddata->pd_gpio, 1);

      return 0;
 err0:

@@ -83,7 +83,7 @@ static void tfp410_power_off(struct omap_dss_device *dssdev)

              return;

      if (gpio_is_valid(ddata->pd_gpio))
-             gpio_set_value(ddata->pd_gpio, 0);
+             gpio_set_value_cansleep(ddata->pd_gpio, 0);

      omapdss_dpi_display_disable(dssdev);
 }
--
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html