Re: [PATCH] video: s3c-fb: Add device tree support

Hi Mark,

On 10 January 2012 10:22, Mark Brown
[off-list ref] wrote:

On Tue, Jan 10, 2012 at 01:31:47AM +0530, Thomas Abraham wrote:

quoted

+Required properties:

quoted

+- gpios: The gpios used to interface with the external LCD panel.

This isn't terribly informative for the user - which GPIOs and in what
order are they specified?  Looking at the code it looks like pin mux
configuration so just some wording saying it's a list of pins to be used
for the framebuffer function.

Ok. I will modify the sentence to mean that it is list of gpios used
by framebuffer controller for data/timing interface with the lcd
panel. Thanks for your review.

Regards,
Thomas.

On Wed, Jan 11, 2012 at 04:34:28PM +0530, Thomas Abraham wrote:

On 10 January 2012 10:22, Mark Brown

quoted

This isn't terribly informative for the user - which GPIOs and in what
order are they specified?  Looking at the code it looks like pin mux
configuration so just some wording saying it's a list of pins to be used
for the framebuffer function.

Ok. I will modify the sentence to mean that it is list of gpios used
by framebuffer controller for data/timing interface with the lcd
panel. Thanks for your review.

You probably want to mention that it's for pin muxing, the reason I
didn't get what it meant on first read was that normally GPIO means
specifically the sort of stuff handled by gpiolib.