Re: [PATCH] video: s3c-fb: Add device tree support

From
Thomas Abraham <hidden>
Date
2012-01-11 11:04:28
Also in
linux-arm-kernel, linux-devicetree, linux-samsung-soc
Hi Mark,

On 10 January 2012 10:22, Mark Brown
[off-list ref] wrote:
On Tue, Jan 10, 2012 at 01:31:47AM +0530, Thomas Abraham wrote:
quoted
+Required properties:
quoted
+- gpios: The gpios used to interface with the external LCD panel.
This isn't terribly informative for the user - which GPIOs and in what
order are they specified?  Looking at the code it looks like pin mux
configuration so just some wording saying it's a list of pins to be used
for the framebuffer function.
Ok. I will modify the sentence to mean that it is list of gpios used
by framebuffer controller for data/timing interface with the lcd
panel. Thanks for your review.

Regards,
Thomas.
Thread (2 messages) 2 messages, 2 authors, last reply 2012-01-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help