MXSFB: Fix driver registration

Started by Marek Vasut on Dec 19, 2011 · 3 messages from 3 authors · Last reply Dec 21, 2011

Subsystems (2)

Maintainers (2)

STALE5442d REVIEWED · 2 reviews, 1 by a maintainer

Status: Reviewed.

2 review trailers.

open the first message on its own page

Message details and related content
The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.

Signed-off-by: Marek Vasut <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Stefano Babic <redacted>
Cc: Shawn Guo <redacted>
Cc: Huang Shijie <redacted>
Cc: Axel Lin <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/mxsfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
 	},
 };
 
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
 
 MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
-- 
1.7.6.4
Message details and related content
On 19 December 2011 23:37, Marek Vasut [off-list ref] wrote:
The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.

Signed-off-by: Marek Vasut <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Stefano Babic <redacted>
Cc: Shawn Guo <redacted>
Cc: Huang Shijie <redacted>
Cc: Axel Lin <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <redacted>

-- 
Regards,
Shawn
Message details and related content
On 12/19/2011 03:37 PM, Marek Vasut wrote:
The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.

Signed-off-by: Marek Vasut <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Stefano Babic <redacted>
Cc: Shawn Guo <redacted>
Cc: Huang Shijie <redacted>
Cc: Axel Lin <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied.


Thanks,

Florian Tobias Schandinat
quoted hunk
---
 drivers/video/mxsfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
 	},
 };
 
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
 
 MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help