Thread (3 messages) flat view 3 messages, 3 authors, 2011-12-21
STALE5381d REVIEWED: 4 (3M)

2 review trailers.

[PATCH RESEND] MXSFB: Fix driver registration

From: Marek Vasut <hidden>
Date: 2011-12-19 15:38:09
Also in: lkml
Subsystem: framebuffer layer, the rest · Maintainers: Helge Deller, Linus Torvalds

The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
This caused obvious null pointer dereference and crash.

Signed-off-by: Marek Vasut <redacted>
Cc: Wolfgang Denk <redacted>
Cc: Stefano Babic <redacted>
Cc: Shawn Guo <redacted>
Cc: Huang Shijie <redacted>
Cc: Axel Lin <redacted>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Axel Lin <redacted>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/video/mxsfb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 18742c2..d29c7c0 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
 	},
 };
 
-module_platform_driver(mxsfb_devtype);
+module_platform_driver(mxsfb_driver);
 
 MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
-- 
1.7.6.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help