Hi,

On Thursday 08 December 2011 01:59 PM, Tomi Valkeinen wrote:

On Wed, 2011-12-07 at 18:35 +0530, Archit Taneja wrote:

quoted

Hi,

On Tuesday 22 November 2011 02:52 PM, Tomi Valkeinen wrote:

quoted

Add checks for overlay and manager settings. The checks are a bit
complex, as we need to observe the bigger picture instead of overlays
and managers independently. Things like the used display and the zorder
of other overlays affect the validity of the settings.

Minor comment:

dss_ovl_check, dss_mgr_check and dss_mgr_check_zorder don't really
qualify as functions which do actual applying of configurations, they
could be moved from apply.c to manager.c and overlay.c.

I had the check functions in apply.c because they used apply.c's
internal datastructures.

However, looking the functions now, only dss_mgr_check_zorder() used the
internal datas, and the function doesn't even use those variables for
anything =).

Also, the function dss_mgr_check() takes 'struct 
omap_overlay_manager_info *info' as a parameter but doesn't use it. We 
might want to remove that too.

Archit

So you're right, they can be moved to manager.c and overlay.c, thanks.

  Tomi