Thread (6 messages) flat view 6 messages, 4 authors, 2011-06-14

Re: [PATCH] efifb: Fix call to wrong unregister function

From: Andy Lutomirski <hidden>
Date: 2011-06-13 02:55:46
Also in: lkml

On 06/12/2011 06:52 AM, wanlong.gao wrote:
quoted hunk ↗ jump to hunk
<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Signed-off-by: Wanlong Gao<redacted>
---
  drivers/video/efifb.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c
@@ -541,7 +541,7 @@ static int __init efifb_init(void)
  	 */
  	ret = platform_driver_probe(&efifb_driver, efifb_probe);
  	if (ret) {
-		platform_device_unregister(&efifb_driver);
+		platform_device_unregister(&efifb_device);
  		return ret;
  	}
Acked-by: Andy Lutomirski <redacted>

That's my bug.  Sorry.  I'm not sure why it compiled, though.

--Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help