re:[PATCH] efifb: Fix call to wrong unregister function

<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Signed-off-by: Wanlong Gao <redacted>
---
 drivers/video/efifb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c

@@ -541,7 +541,7 @@ static int __init efifb_init(void)
 	 */
 	ret = platform_driver_probe(&efifb_driver, efifb_probe);
 	if (ret) {
-		platform_device_unregister(&efifb_driver);
+		platform_device_unregister(&efifb_device);
 		return ret;
 	}
 

-- 
1.7.4.1

Hey,

2011/6/12 wanlong.gao [off-list ref]:

<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Ah yes, that seems to be the correct one, platform_driver_register was
removed. Not 100% sure if acked by or signed-off-by is appropriate
here.

Signed-off-by: Maarten Lankhorst <redacted>

~Maarten

On æ—¥, 2011-06-12 at 19:48 +0200, Maarten Lankhorst wrote:

Hey,

2011/6/12 wanlong.gao [off-list ref]:

quoted

<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Ah yes, that seems to be the correct one, platform_driver_register was
removed. Not 100% sure if acked by or signed-off-by is appropriate
here.

I think signed-off-by is OK.

Signed-off-by: Maarten Lankhorst <redacted>

~Maarten

On 06/12/2011 06:52 AM, wanlong.gao wrote:

Acked-by: Andy Lutomirski <redacted>

That's my bug.  Sorry.  I'm not sure why it compiled, though.

--Andy

Hi Andy,

2011/6/13 Andy Lutomirski [off-list ref]:

On 06/12/2011 06:52 AM, wanlong.gao wrote:

quoted

<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Signed-off-by: Wanlong Gao<redacted>
---
 drivers/video/efifb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c

@@ -541,7 +541,7 @@ static int __init efifb_init(void)

        */
       ret = platform_driver_probe(&efifb_driver, efifb_probe);
       if (ret) {
-               platform_device_unregister(&efifb_driver);
+               platform_device_unregister(&efifb_device);
               return ret;
       }

Acked-by: Andy Lutomirski <redacted>

That's my bug.  Sorry.  I'm not sure why it compiled, though.

It compiled, but threw a warning. :)

~Maarten

On Sun, Jun 12, 2011 at 10:55:37PM -0400, Andy Lutomirski wrote:

On 06/12/2011 06:52 AM, wanlong.gao wrote:

quoted

<snip>

Hi Maarten:
It registered efifb_device but try to unregistered efifb_driver,
so I think you should fix it like this?

Signed-off-by: Wanlong Gao<redacted>
---
 drivers/video/efifb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
index 69c49df..784139a 100644
--- a/drivers/video/efifb.c
+++ b/drivers/video/efifb.c

@@ -541,7 +541,7 @@ static int __init efifb_init(void)
 	 */
 	ret = platform_driver_probe(&efifb_driver, efifb_probe);
 	if (ret) {
-		platform_device_unregister(&efifb_driver);
+		platform_device_unregister(&efifb_device);
 		return ret;
 	}

Acked-by: Andy Lutomirski <redacted>

Updated version applied, thanks.