Thread (20 messages) 20 messages, 6 authors, 2010-09-22

Re: [Patch, RFC] Make struct fb_info ref-counted with kref

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2010-09-20 08:27:41
Also in: lkml

On Sun, Sep 19, 2010 at 18:47, Florian Tobias Schandinat
[off-list ref] wrote:
Bruno Prémont schrieb:
quoted
diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
index 0a08f13..be5f342 100644
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -58,6 +58,7 @@ struct fb_info *framebuffer_alloc(size_t size, struct
device *dev)
               info->par = p + fb_info_size;
       info->device = dev;
+       kref_init(&info->refcount);
As far as I know there exist framebuffer drivers which do not call
framebuffer_alloc but contain their own fb_info. I guess these would be
broken as well.
Those should be converted to framebuffer_alloc() anyway. Janitors?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help