Re: [PATCH 4/4] HID: picolcd: implement refcounting of framebuffer
From: Bernie Thompson <bernie@plugable.com>
Date: 2010-06-28 21:26:54
From: Bernie Thompson <bernie@plugable.com>
Date: 2010-06-28 21:26:54
On Mon, Jun 28, 2010 at 1:33 PM, Bruno Prémont [off-list ref] wrote:
As our device may be hot-unplugged and framebuffer cannot handle this case by itself we need to keep track of usage count so as to release fb_info and framebuffer memory only after the last user has closed framebuffer. We need to do the freeing in a scheduled work as fb_release() is called with fb_info lock held.
The udlfb (DisplayLink) framebuffer driver just got a similar fix in the last few days: http://git.plugable.com/gitphp/index.php?p=udlfb&a=commit&h®0502457e54904b1a9e0d67db6719182824da7c The need to schedule work in fb_release() because fbmem.c touches it after release is especially unfortunate (we had to do the same). Anyone have existing thoughts about fixing the release path more centrally? Best wishes, Bernie http://plugable.com/