Re: [PATCHv3 1/5] OMAP: RX51: Add LCD Panel support
From: Kevin Hilman <hidden>
Date: 2010-05-06 18:27:26
Also in:
linux-omap
Roger Quadros [off-list ref] writes:
From: Roger Quadros <redacted> Adds basic support for LCD Panel on Nokia N900 Signed-off-by: Roger Quadros <redacted>
Just noticed a compile problem here... [...]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-omap2/board-rx51-video.c b/arch/arm/mach-omap2/board-rx51-video.c
[...]
+void __init rx51_video_mem_init(void)
+{
+ /*
+ * GFX 864x480x32bpp
+ * VID1/2 1280x720x32bpp double buffered
+ */
+ omap_vram_set_sdram_vram(PAGE_ALIGN(864 * 480 * 4) +
+ 2 * PAGE_ALIGN(1280 * 720 * 4 * 2), 0);
+}
+
+#endif /* defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) */This function is available conditionally based on the #ifdefs, but...
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c index b155c36..1b86b5b 100644 --- a/arch/arm/mach-omap2/board-rx51.c +++ b/arch/arm/mach-omap2/board-rx51.c@@ -36,6 +36,7 @@ #define RX51_GPIO_SLEEP_IND 162 struct omap_sdrc_params *rx51_get_sdram_timings(void); +extern void rx51_video_mem_init(void); static struct gpio_led gpio_leds[] = { {@@ -143,6 +144,7 @@ static void __init rx51_init(void) static void __init rx51_map_io(void) { omap2_set_globals_343x(); + rx51_video_mem_init();
... here it is always called, giving a compiler error when building without FB support. Kevin