Re: [Linux-fbdev-devel] [REVIEW PATCH 8/9] DSS: support for Beagle Board
From: Tony Lindgren <tony@atomide.com>
Date: 2008-11-04 18:24:29
Also in:
linux-omap
Hi, One comment below. * Tomi Valkeinen [off-list ref] [081104 08:32]:
quoted hunk ↗ jump to hunk
Signed-off-by: Tomi Valkeinen <redacted> --- arch/arm/mach-omap2/board-omap3beagle.c | 121 ++++++++++++++++++++++++++++--- 1 files changed, 108 insertions(+), 13 deletions(-)diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index ce6c7b4..a6fe63d 100644 --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c
<snip>
+static struct omap_fbmem_config beagle_fbmem0_config = {
+ .size = 1024*768*4,
+ .start = OMAPFB_MEMTYPE_SDRAM,
+};
+
+static struct omap_fbmem_config beagle_fbmem1_config = {
+ .size = 1024*768*4,
+ .start = OMAPFB_MEMTYPE_SDRAM,
+};
+
+static struct omap_fbmem_config beagle_fbmem2_config = {
+ .size = 1024*768*4,
+ .start = OMAPFB_MEMTYPE_SDRAM,
+};
+
+
static struct omap_board_config_kernel omap3_beagle_config[] __initdata = {
{ OMAP_TAG_UART, &omap3_beagle_uart_config },
- { OMAP_TAG_LCD, &omap3_beagle_lcd_config },
+ { OMAP_TAG_FBMEM, &beagle_fbmem0_config },
+ { OMAP_TAG_FBMEM, &beagle_fbmem1_config },
+ { OMAP_TAG_FBMEM, &beagle_fbmem2_config },
};
NAK for adding new OMAP_TAGs. We are in process of removing those. You should be able to use just board specific platform_data. If there are ATAGs that are needed, they must be ARM generic. They also need to be acked by Russell King on the linux-arm-kernel mailing list. I doubt that you'll need those though. Regards, Tony