Re: [PATCH] Add fb_check_var() for fixed mode device.
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-08-29 14:15:06
On Fri, 29 Aug 2008, Michel D�nzer wrote:
On Fri, 2008-08-29 at 14:16 +0200, Geert Uytterhoeven wrote:quoted
| X.Org X Server 1.4.2[...]quoted
| (EE) FBDEV(0): FBIOPUT_VSCREENINFO succeeded but modified mode[...]quoted
Hence Xorg is broken on all embedded devices with a frame buffer driver that supports a single fixed video mode only?No. As discussed before, you're probably missing http://cgit.freedesktop.org/xorg/xserver/commit/?id=c095da04fe7c73b6503ef5b93549b13796c51b22 which is in the upcoming xserver 1.5 release.
Ah, upcoming. That's not current/previous/... ;-)
(BTW, would you happen to remember what the magic pixclock value was there for in the first place? :)
To avoid a division by zero exception? I guess I just took a value that
looked sensible.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds