Re: [PATCH] i.MX Framebuffer: Use iowrite/ioread instead of direct pointer deref
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-08-20 20:23:48
On Wed, 20 Aug 2008, Krzysztof Helt wrote:
On Wed, 20 Aug 2008 18:31:09 +0200 Sascha Hauer [off-list ref] wrote:quoted
On Wed, Aug 20, 2008 at 05:31:59PM +0200, Krzysztof Helt wrote:quoted
On Tue, 19 Aug 2008 17:06:41 +0200 Sascha Hauer [off-list ref] wrote:quoted
+#define DRIVER_NAME "imx-fb" +All constants below should really be put into the imxfb.h. There is already such a file.AFAIK the-new-beautiful-way is not to have these header files next to the .c files at all and put this stuff into the .c file. So maybe it's better to move the rest of imxfb.h here aswell.I was not aware about "the-new-beautiful-way". I am just curious about this. Normally, the headers for frame buffers are located at include/video. It can stay this way (no header) if you insist.
If the header file is included by a single source file only, it doesn't
make much sense to have the separate header file.
include/video/ is for header files that are included by multiple source
files, some outside drivers/video/.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/