Re: [PATCH 1/13 v2] viafb: viafb.modes, viafb.txt

	Hi Joseph,

On Mon, 11 Aug 2008, JosephChan@via.com.tw wrote:

quoted

Please send an incremental patch.

Do you mean that I can send a signle patch for fixing this issue. (v2 -> v3)

Yes.

And the subject of this mail should be " [PATCH 1/13 v3] viafb: viafb.modes, viafb.txt"

Please also add `fix for' to the subject, so Andrew, sees its
incremental.

-----Original Message-----
From: geert@linux-m68k.org [mailto:geert@linux-m68k.org] 
Sent: Friday, August 08, 2008 11:25 PM
To: Joseph Chan
Cc: linux-fbdev-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org; akpm@linux-foundation.org
Subject: RE: [PATCH 1/13 v2] viafb: viafb.modes, viafb.txt

On Fri, 8 Aug 2008, JosephChan@via.com.tw wrote:

quoted

It should be my carelessness. The check has been added in viafbdev.c already. 

OK.

quoted

Do I need to re-send the patch for the documentation? Thanks for your reminding.

Please send an incremental patch. Andrew is good in folding ;-)

quoted

On Fri, 8 Aug 2008, JosephChan@via.com.tw wrote:

quoted

+    4. VX800 2D accelerator hasn't been supported in this driver yet. When
+       using driver on VX800, one should add parameter "viafb_accel=0" to
+       disable 2D accelerator.

Can't the driver detect this automatically, and disable the 2D 
accelerator when running on a VX800?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/