Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2008-03-20 22:34:13
Also in:
linuxppc-dev, lkml
On Wed, 19 Mar 2008 13:50:27 -0500 York Sun [off-list ref] wrote:
Add platform code to support Freescale DIU. The platform code includes framebuffer memory allocation, pixel format, monitor port, etc. ... +unsigned int mpc8610hpcd_get_pixel_format + (unsigned int bits_per_pixel, int monitor_port)
Again, please do unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel, int monitor_port) (and anywhere else where this was done)
+int __init preallocate_diu_videomemory(void);
Nope, please don't put extern declarations in .c files. Find a suitable header for it - one which is included by the defining file and by all users of the symbol. Andy, checkpatch missed this.
} #endif +
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/