Re: [PATCH] fbcon: replace mono_col macro with static inline

On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote:

On Tue, 26 Feb 2008, Harvey Harrison wrote:

quoted

On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote:

quoted

On Mon, 25 Feb 2008, Harvey Harrison wrote:

quoted

+static inline int mono_col(struct fb_info *info)

                              ^^^^^^^^^^^^^^^^^^^^
const struct fb_info *info?

I suppose, but seeing as it's an inline, does it really matter?

Sure, if one day a new routine calls mono_col() passing a const struct fb_info
pointer, it won't compile.

Fair enough, want an updated patch, or will Andrew just make the small
addition?

Harvey


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/