Thread (4 messages) 4 messages, 2 authors, 2008-02-26

Re: [PATCH] fbcon: replace mono_col macro with static inline

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2008-02-26 21:36:36
Also in: lkml

On Tue, 26 Feb 2008, Harvey Harrison wrote:
On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote:
quoted
On Mon, 25 Feb 2008, Harvey Harrison wrote:
quoted
+static inline int mono_col(struct fb_info *info)
                              ^^^^^^^^^^^^^^^^^^^^
const struct fb_info *info?
I suppose, but seeing as it's an inline, does it really matter?
Sure, if one day a new routine calls mono_col() passing a const struct fb_info
pointer, it won't compile.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help