Re: [PATCH 01/11] fbcon: Kill compile warning

On Wed, 2007-08-01 at 15:41 -0700, Andrew Morton wrote:

On Wed, 01 Aug 2007 15:33:09 +0800
"Antonino A. Daplas" [off-list ref] wrote:

quoted

+static inline void fbcon_map_override(void)
+{
+	map_override = 1;
+}
+#else
+#define fbcon_map_override(...) do { } while (0)
+#endif /* CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY */

It's odd to use a C function in one case and a macro in the other.
Was there a reason to not use plain old static inline?

No reason, an empty inline function is fine with me too.

Tony


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/