Thread (3 messages) 3 messages, 2 authors, 2007-08-02

Re: [PATCH 01/11] fbcon: Kill compile warning

flat view

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-08-01 22:42:24

On Wed, 01 Aug 2007 15:33:09 +0800
"Antonino A. Daplas" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+static inline void fbcon_map_override(void)
+{
+	map_override = 1;
+}
+#else
+#define fbcon_map_override(...) do { } while (0)
+#endif /* CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY */
It's odd to use a C function in one case and a macro in the other.
Was there a reason to not use plain old static inline?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help