Re: [PATCH] EFI framebuffer on EFI X86_64

From: geert@linux-m68k.org [mailto:geert@linux-m68k.org]
Sent: 2007年7月5日 0:54
To: Huang, Ying
Cc: Linux Frame Buffer Device Development
Subject: Re: [Linux-fbdev-devel] [PATCH] EFI framebuffer on EFI X86_64

On Wed, 4 Jul 2007, Huang, Ying wrote:

quoted

diff -uprN -X linux-2.6.21-orig/Documentation/dontdiff
linux-2.6.21-orig/drivers/video/efifb.c
linux-2.6.21-uefi-finaltest4/drivers/video/efifb.c

Your mail client seems to corrupt whitespace...

Sorry, will be more careful next time.

quoted

+       //size_total = screen_info.lfb_size * 65536;

Please don't use C++-style comments. You can use scripts/checkpatch.pl
to perform some basic style checks on your patches.

Ok, will check with scripts/checkpatch.pl firstly next time.

quoted

+#ifndef __i386__
+       //screen_info.imacpm_seg = 0;
+#endif

Superfluous block?

Will delete next time.

Best Regards,
Huang, Ying