On Wed, 4 Jul 2007, Huang, Ying wrote:

diff -uprN -X linux-2.6.21-orig/Documentation/dontdiff
linux-2.6.21-orig/drivers/video/efifb.c
linux-2.6.21-uefi-finaltest4/drivers/video/efifb.c

Your mail client seems to corrupt whitespace...

+       //size_total = screen_info.lfb_size * 65536;

Please don't use C++-style comments. You can use scripts/checkpatch.pl
to perform some basic style checks on your patches.

+#ifndef __i386__
+       //screen_info.imacpm_seg = 0;
+#endif

Superfluous block?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/