Re: [PATCH 2/2] intelfb/fbdev: Save info->flags in a local variable
flat view
From: James Simmons <hidden>
Date: 2005-08-15 16:31:59
quoted hunk ↗ jump to hunk
fbmem.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c@@ -643,8 +643,8 @@ fb_pan_display(struct fb_info *info, str int fb_set_var(struct fb_info *info, struct fb_var_screeninfo *var) { - int err; - + int err, flags = info->flags; + if (var->activate & FB_ACTIVATE_INV_MODE) { struct fb_videomode mode1, mode2; int ret = 0;@@ -697,7 +697,7 @@ fb_set_var(struct fb_info *info, struct !list_empty(&info->modelist)) err = fb_add_videomode(&mode, &info->modelist); - if (!err && info->flags & FBINFO_MISC_USEREVENT) { + if (!err && flags & FBINFO_MISC_USEREVENT) { struct fb_event event; int evnt = (var->activate & FB_ACTIVATE_ALL) ? FB_EVENT_MODE_CHANGE_ALL :
I take that back. I misread the code. You are not overwriting the new flag. The patch is good :-) ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf