Re: [PATCH 2/2] intelfb/fbdev: Save info->flags in a local variable

  This bug is caused by intelfb unintentionally destroying info->flags in
  set_par(). Therefore the flag, FBINFO_MISC_USEREVENT used to notify
  fbcon of a mode change was cleared causing the above problem. This bug
  though is not intelfb specific, as other drivers may also be affected.

  The fix is to save info->flags in a local variable before calling any
  of the driver hooks.  A more definitive fix (for post 2.6.13) is to
  separate info->flags into one that is set by the driver and another that
  is set by core fbdev/fbcon.

The only problem I have with that patch is that the flags variable can 
also contain what accelerated features the driver supports in that mode.
It is possible to have a old mode that supports no hardware acceleration 
and then change to a mode that does. Save the whole flag has us lose that 
information. What I suggest is that we mask the flag to save the upper 
bits and save only those. Then after mode switching OR it with the new 
mask. 



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf