James Simmons wrote:
What is wrong with brekaing this patch into smaller pieces????????????
I'm not getting a answer!!!!! As I said no giant patches that tocuh every driver.
quoted
quoted
has software image blit and hardware fillrect. You want to have fbcon use
Then the driver sets fbops->fb_cursor with its own version that does fillrect instead of imageblit.
No. fb_cursor is only used for a hardware cursor case.
And what happens if the driver does not have support for a hardware cursor?
quoted
If you want to add userspace support for hardware cursors then you have to
create another API. If you don't want another API, then forget about userspace
support. Overloading fbops->fb_cursor is not the answer.
So fbops->fb_cursor will not be used at all for the console?
You're getting it backwards. fbops->fb_cursor is for the console. If you want
userspace hardware cursor, then we need a new API. It's not something that I
want, just a fact. Look at the code. Remember, I wrote the orginal fb_cursor
code, so I know its limitations. The sole purpose was to replace the 2.4
permanently blinking block and to allow users to have a choice of using an
underline or block cursor.
But to overload fbops->fb_cursor for use in userspace will just introduce new
headaches and will be painful to debug.
Look the patch I sent is small and doesn't interfere with many drivers. It does stop your desires either. Personally softcursor should go away.
And force all maintainers to write forhardware cursor support? Even X doesn't have
that 100% support. Might as well remove cfbimageblit, cfbfillrect and
cfbcopyarea too, if that's what you want.
Tony
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf