James Simmons wrote:
quoted
This patch forbids the cursor use from userland. The reason is that the
cursor area could be altered by a another process and the current system
doesn't handle syncing those updates.
I don't really like this change. I prefer Jon's proposal of setting
fbops->fb_cursor = NULL and moving softcursor.c to drivers/video/console.
This will slash > 200 lines of source code and several bytes from the kernel
image size. Plus it's cleaner.
One change at a time. If you want to properly do cursor in fbcon then just
moving softcursor there is not the answer. What if you have a driver that
has software image blit and hardware fillrect. You want to have fbcon use
the hardware fillrect to draw the cursor using xor mode. See the problem
is more than just moving softcursor.c. Softcursor.c should go away
completely.
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf