Re: Re: [PATCH] mach64 atari patch
flat view
From: James Simmons <hidden>
Date: 2005-08-08 18:49:29
quoted
au1100fb int nohwcursor intelfb int hwcursor nvidia int hwcur cyberfb You need to remove this!!!! What I am arguing is that drivers with hardware cursor support should be able to turn off and on hardware cursor support. That is why the HWACCEL_CURSOR flag. Your test the fb_cursor field prevents this!!!If you want fbconsole to use the software cusor instead of the hardware cursor, that's between you and fbconsole to decide. Control over that choice needs to be in fbconsole, not the base fbdev. The fbdev drivers should just unconditionally offer the hardware cursor if they support it. It is up to the user of the cursor to choose whether to use it or ignore it.
Finally you see the point I was making. I wanted it be very clear to every one here the implications of your changes. You remove the power to control the use of a hardware cursor from the driver. At this point driver writers need to speak up if they have no problem with this. P.S The patch still needs to broken into smaller pieces. ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf