Re: Re: [PATCH] mach64 atari patch

On 8/8/05, James Simmons [off-list ref] wrote:

quoted

quoted

quoted

I just don't think this patch is as complex as you are making it out
to be. It is large simply because the same action has been repeated
for each of the 65 drivers. The action is only a simple deletion of
two lines.

I'm not arguing over this. What is wrong with breaking this patch up!!!!!
I still have no answer to this!!!! I'm using the hardware flag because
sometimes the driver that does have a hardware cursor wants to turn
support off for it.

Set  .fb_cursor = NULL; to turn off the support.

So forbid hardware drivers that support hware cursors to never turn off
there hardware cursor support!!!!!

Let see what drivers have a flag to control using the hardware cursor.

au1100fb        int nohwcursor
intelfb         int hwcursor
nvidia          int hwcur
cyberfb

You need to remove this!!!!

What I am arguing is that drivers with hardware cursor support should be
able to turn off and on hardware cursor support. That is why the
HWACCEL_CURSOR flag. Your test the fb_cursor field prevents this!!!

If you want fbconsole to use the software cusor instead of the
hardware cursor, that's between you and fbconsole to decide. Control
over that choice needs to be in fbconsole, not the base fbdev.

The fbdev drivers should just unconditionally offer the hardware
cursor if they support it. It is up to the user of the cursor to
choose whether to use it or ignore it.

-- 
Jon Smirl
jonsmirl@gmail.com


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf