Re: PATCH: move soft_cursor into fbconsole

Ug no. I see in the future more drivers using hardware cursors instead.
We would be carry around extra software cursor code in the the framebuffer 
console all the time. We need to properly fix the cursor code. Unfortunely 
that will take more work. In the mean time please encourage people to 
support hardware cursors. Even crappy cards have hardware cursors most of 
the time.

On Sat, 11 Jun 2005, Jon Smirl wrote:

James has indicated that the soft_cursor only works with fbconsole and
it won't work from user space. This means that soft_cursor is in the
way of using a hardware cursor from user space. This patch removes
soft_cursor from all of the drivers. So if the driver doesn't support
a hardware cursor fb_cursor is NULL.

I also fixed the three drivers with hardware implementation. These
drivers had cases where the hardware cursor had an error and then
returned the software one instead. Now they return -ENODEV when they
can't use the hardware one.

In console/bitlbt.c I made this change:
	/* First try the hardware cursor */
	if (info->fbops->fb_cursor)
		err = info->fbops->fb_cursor(info, &cursor);
	/* if that doesn't exist or didn't work, use the software one */
	if (err)
		soft_cursor(info, &cursor);

The effect of all of this is the make a clear path for getting to
hardware cursors without triggering the soft_cursor fallback.
Triggering of the fallback was moved into fb_console. This also lets
me remove the softcursor module from memory when fb_console is not
loaded.

Give this a try and let me know what you think. 

-- 
Jon Smirl
jonsmirl@gmail.com

-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.  
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20