Re: Re: [PATCH][RFC] Add support for Epson S1D13806 FB

On Mon, 14 Mar 2005, Paul Mundt wrote:

On Mon, Mar 14, 2005 at 08:15:13PM +0800, Antonino A. Daplas wrote:

quoted

3. You can use pci_resource_len()/pci_resource_start() instead of

+	info->fix.mmio_start = pdev->resource[1].start;
+	info->fix.mmio_len = pdev->resource[1].end - pdev->resource[1].start;

+1?

quoted

+	info->fix.smem_start = pdev->resource[0].start;
+	info->fix.smem_len = pdev->resource[0].end - pdev->resource[0].start;

+1?

quoted

+

No, the pdev here refers to a platform device, not a pci device.

While the pci_resource_xxx() routines would still technically do the
right thing, this is purely coincidental.

Nah, they would work better here, since they do include the +1 ;-)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click