Re: PATCH Proposal make FB_ACCEL_ private to the driver
From: Ville Syrjälä <syrjala@sci.fi>
Date: 2005-02-28 13:41:01
On Sun, Feb 27, 2005 at 11:17:15PM +0100, Henk Vergonet wrote:
On Sun, Feb 27, 2005 at 07:28:47PM +0100, Geert Uytterhoeven wrote:quoted
On Sun, 27 Feb 2005, Henk Vergonet wrote: I'm afraid you will never see this reply, as rememberme@systol.god.lan won't resolve....It is intentional, but if it's a problem I can fix it.quoted
quoted
I want to propose to localize the maintenance and registration of the FB_ACCEL_ id's and remove it from the public fb.h include file. Motivation: - This removes an unneeded dependency to fb.h if an additional cards/chips are introduced. (These id's are only interesting for the driver anyhow. Only fbset will print out the id, but I'll doubt this is used by anyone.)Yes, it's used by userspace apps that need to know the graphics card type (e.g. DirectFB and the good old XF68_FBDev).My point is not that there are no userspace utils that use it. But that we should lose this identifier in the public interface eventually because it introduces unneeded dependencies as stated in my earlier post. If it's used by userspace in any other way than for pure informational purposes: For example to make certain assumptions on hardware capabilities, locations of specific hardware registers ...) then that's ok but should be considered as a make-shift solution until we have found a better solution drivers/API.
And that is exactly how DirectFB uses it. Case closed :) -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click