Thread (4 messages) flat view 4 messages, 3 authors, 2005-02-28

PATCH Proposal make FB_ACCEL_ private to the driver

From: Henk Vergonet <hidden>
Date: 2005-02-27 03:26:15

Hi gents,

This post was originally posted to the kernel-janitors list. After which
I learned there was an active development-list for linux-framebuffer stuff. 


-------------------------

I want to propose to localize the maintenance and registration of the
FB_ACCEL_ id's and remove it from the public fb.h include file.

Motivation:
- This removes an unneeded dependency to fb.h if an additional cards/chips are
  introduced. (These id's are only interesting for the driver anyhow. 
  Only fbset will print out the id, but I'll doubt this is used by anyone.)
- It relieves maintenance of the common frambuffer code, because we don't have
  to keep fb.h in sync.
- It also relieves the maintenance for the  driver developer
  because he can add new cards without having to request modifications
  to public framebuffer code.
  => cleaner fb.h

Could we make this a general guideline?


I have created a patch for the savage driver and fb.h to give an idea
how this would look like. It has no impact on the other fb drivers.

Best regards,

Henk Vergonet

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help